Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning and notice to flyte-cli #730

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

eapolinario
Copy link
Collaborator

Signed-off-by: Eduardo Apolinario [email protected]

TL;DR

Add deprecation notice to flyte-cli

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This is how executions of flyte-cli look like now:

❯ flyte-cli setup-config --host="localhost:30081" --insecure
...
DeprecationWarning: The command flyte-cli is deprecated.

################################################################################################################################
# flyte-cli is being deprecated in favor of flytectl. More details about flytectl in https://docs.flyte.org/projects/flytectl/ #
################################################################################################################################

Welcome to Flyte CLI! Version: 0.0.0+develop

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #730 (fb55e07) into master (d33fb75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   85.78%   85.79%           
=======================================
  Files         362      362           
  Lines       30007    30010    +3     
  Branches     2444     2444           
=======================================
+ Hits        25743    25746    +3     
  Misses       3621     3621           
  Partials      643      643           
Impacted Files Coverage Δ
flytekit/clis/flyte_cli/main.py 47.38% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33fb75...fb55e07. Read the comment docs.

@eapolinario eapolinario merged commit 751425d into master Nov 1, 2021
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
* Add deprecation warning and notice to flyte-cli

Signed-off-by: Eduardo Apolinario <[email protected]>

* Linting

Signed-off-by: Eduardo Apolinario <[email protected]>

Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Robert Everson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants