Cookie cutter initial template #738
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import click | ||
| from cookiecutter.main import cookiecutter | ||
| from cookiecutter.prompt import read_user_variable | ||
|
|
||
|
|
||
| @click.command("init") | ||
| @click.option("--template", default="simple-example", help="cookiecutter template to be used") | ||
| @click.argument("project-name") | ||
| def init(template, project_name): | ||
| """ | ||
| Create flyte-ready projects. | ||
| """ | ||
| click.echo( | ||
| "What should we call your application? This serves as the top level package where your workflows will live." | ||
| ) | ||
| app = read_user_variable("app", "myapp") | ||
| click.echo("What should be the name of your example workflow?") | ||
| workflow_name = read_user_variable("workflow", "workflow_example") | ||
|
There was a problem hiding this comment. Should we just use click for consistency http://pallets-click.readthedocs.io/en/stable/prompts.html There was a problem hiding this comment. using cookiecutter just for the templating feels less cluttered. Thanks for the suggestion! |
||
|
|
||
| config = { | ||
| "project_name": project_name, | ||
| "app": app, | ||
| "workflow": workflow_name, | ||
| } | ||
| cookiecutter( | ||
| "https://github.com/flyteorg/flytekit-python-template.git", | ||
| # TODO: remove this once we make the transition to cookie-cutter official. | ||
| checkout="cookie-cutter", | ||
| no_input=True, | ||
| # We do not want to clobber existing files/directories. | ||
| overwrite_if_exists=False, | ||
| extra_context=config, | ||
| # By specifying directory we can have multiple templates in the same repository, | ||
| # as described in https://cookiecutter.readthedocs.io/en/1.7.2/advanced/directories.html. | ||
| # The idea is to extend the number of templates, each in their own subdirectory, for example | ||
| # a tensorflow-based example. | ||
| directory=template, | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| .[all-spark2.4] | ||
| -r requirements.in |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also eventually I think the repo itself should be parameterizable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this idea of exposing the repo is interesting. So your expectation is that people will have their own private (or public forks) of the repo? In any case, if the need arises we can definitely go that way, but not in this PR, ok?