Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pyarrow max version requirement #741

Merged
merged 2 commits into from
Nov 8, 2021
Merged

remove pyarrow max version requirement #741

merged 2 commits into from
Nov 8, 2021

Conversation

cosmicBboy
Copy link
Contributor

Signed-off-by: Niels Bantilan [email protected]

TL;DR

Need to update the pyarrow version max, as there's a conflict with the feast plugin:

Could not find a version that matches pyarrow<4.0.0,>=2.0.0,>=4.0.0 (from flytekit==0.23.1->-r requirements.in (line 1))
Tried: 0.9.0, 0.10.0, 0.11.0, 0.11.1, 0.12.0, 0.12.1, 0.13.0, 0.14.0, 0.15.1, 0.16.0, 0.16.0, 0.17.0, 0.17.0, 0.17.1, 0.17.1, 1.0.0, 1.0.0, 1.0.1, 1.0.1, 2.0.0, 2.0.0, 2.0.0, 3.0.0, 3.0.0, 3.0.0, 4.0.0, 4.0.0, 4.0.0, 4.0.1, 4.0.1, 4.0.1, 5.0.0, 5.0.0, 5.0.0, 6.0.0, 6.0.0, 6.0.0
There are incompatible versions in the resolved dependencies:
  pyarrow>=4.0.0 (from feast[aws]==0.14.1->-r requirements.in (line 4))
  pyarrow<4.0.0,>=2.0.0 (from flytekit==0.23.1->-r requirements.in (line 1))

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

There are new versions of pyarrow available but flytekit sets a max for pyarrow<4.0.0

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy changed the title update pyarrow version remove pyarrow max version requirement Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #741 (f884c70) into master (d7c382f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #741   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files         341      341           
  Lines       28915    28915           
  Branches     2381     2381           
=======================================
  Hits        24755    24755           
  Misses       3527     3527           
  Partials      633      633           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c382f...f884c70. Read the comment docs.

@cosmicBboy cosmicBboy merged commit c4f33c6 into master Nov 8, 2021
@cosmicBboy cosmicBboy deleted the update-pyarrow branch November 8, 2021 16:24
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
* update pyarrow version

Signed-off-by: Niels Bantilan <[email protected]>

* remove pyarrow max version

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Robert Everson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants