Workflow fetch and sub-workflows #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2020 18:57
wild-endeavor
requested review from
kumare3 and
matthewphsmith
as code owners
added 4 commits
January 29, 2020 17:48
added 15 commits
February 13, 2020 15:08
…n the promote cycle
added 2 commits
March 9, 2020 12:05
matthewphsmith
previously approved these changes
Mar 9, 2020
matthewphsmith
approved these changes
Mar 9, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Please see flyteorg/flyte#139 for additional context. * Completes the SdkWorkflow.promote_from_model functionality. Promoting from model now optionally takes subworkflows and tasks. If specified, the ones provided will be used instead of fetching from Admin. * Enables the sub-workflow behavior * Updates flyteidl to a version that has sub-workflows in the workflow creation request to Admin. * Calling an SdkWorkflow now produces a node. * `SdkTaskNode` and `SdkWorkflowNode` have been moved into a separate file from nodes.py. Related things but don't have time to put into this PR: * Proper serialization of components (we want to use the same construct as the current registration call path) * How do you not register subworkflows, but do register them if they're also standalone workflows, and always use the correct name, and also always have the correct dependency structure when doing the topologic sort. * Discovered that we have duplicate `CompiledTask` models while writing this PR but will fix later. Left a todo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see flyteorg/flyte#139 for additional context.
SdkTaskNodeandSdkWorkflowNodehave been moved into a separate file from nodes.py.Related things but don't have time to put into this PR:
CompiledTaskmodels while writing this PR but will fix later. Left a todo.