Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getfullargspec in Python 3 to avoid deprecation warnings #8

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

matthewphsmith
Copy link
Collaborator

Get rid of deprecated warning on py3 while retaining py2.7 compat.

@generalzhou
Copy link

+1, nice, thanks!

@matthewphsmith matthewphsmith merged commit a52a310 into master Aug 28, 2019
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
Use getfullargspec in Python 3 to avoid deprecation warnings
ByronHsu added a commit to ByronHsu/flytekit that referenced this pull request May 29, 2023
wild-endeavor added a commit that referenced this pull request Sep 26, 2023
eapolinario added a commit that referenced this pull request Feb 8, 2024
* temp

Signed-off-by: Yee Hing Tong <[email protected]>

* stuff

Signed-off-by: Yee Hing Tong <[email protected]>

* temp

Signed-off-by: Yee Hing Tong <[email protected]>

* scaffolding areas mostly identified

Signed-off-by: Yee Hing Tong <[email protected]>

* add artifact to upload request

Signed-off-by: Yee Hing Tong <[email protected]>

* remove an unnecessary line in workflow

Signed-off-by: Yee Hing Tong <[email protected]>

* finish adding examples use cases maybe

Signed-off-by: Yee Hing Tong <[email protected]>

* add project/dom to get query

Signed-off-by: Yee Hing Tong <[email protected]>

* add from flyte idl

Signed-off-by: Yee Hing Tong <[email protected]>

* add project domain to as query

Signed-off-by: Yee Hing Tong <[email protected]>

* add condition in parameter to flyte idl

Signed-off-by: Yee Hing Tong <[email protected]>

* test stuff

* Remove artifactID from literal oneof, add to metadata (#2)

* Triggers (#6)

* Minor changes to get time series example working #8

Signed-off-by: Yee Hing Tong <[email protected]>

* switch channel (#10)

Signed-off-by: Yee Hing Tong <[email protected]>

* fix tests ignore - pr into other pr (#1858)

Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/update idl ux (#1920)


Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/trigger (#1948)

* Add triggers
* Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now.

Signed-off-by: Yee Hing Tong <[email protected]>

* remove the now deleted artifact spec (#1984)

Signed-off-by: Yee Hing Tong <[email protected]>

* Literal metadata model update (#2089)


Signed-off-by: Yee Hing Tong <[email protected]>

* Separate time partition (#2114)



Signed-off-by: Yee Hing Tong <[email protected]>

* Split service code (#2136)


Signed-off-by: Yee Hing Tong <[email protected]>

* remove empty files

Signed-off-by: Yee Hing Tong <[email protected]>

* add noneness check to metadata and add test

Signed-off-by: Yee Hing Tong <[email protected]>

* remove sandbox test for now

Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/cleanup (#2158)

* add a test

Signed-off-by: Yee Hing Tong <[email protected]>

* try updates

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>

* Use python 3.9 to run make doc-requirements.txt

Signed-off-by: Eduardo Apolinario <[email protected]>

* reasons not msg

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario added a commit that referenced this pull request Feb 8, 2024
* temp

Signed-off-by: Yee Hing Tong <[email protected]>

* stuff

Signed-off-by: Yee Hing Tong <[email protected]>

* temp

Signed-off-by: Yee Hing Tong <[email protected]>

* scaffolding areas mostly identified

Signed-off-by: Yee Hing Tong <[email protected]>

* add artifact to upload request

Signed-off-by: Yee Hing Tong <[email protected]>

* remove an unnecessary line in workflow

Signed-off-by: Yee Hing Tong <[email protected]>

* finish adding examples use cases maybe

Signed-off-by: Yee Hing Tong <[email protected]>

* add project/dom to get query

Signed-off-by: Yee Hing Tong <[email protected]>

* add from flyte idl

Signed-off-by: Yee Hing Tong <[email protected]>

* add project domain to as query

Signed-off-by: Yee Hing Tong <[email protected]>

* add condition in parameter to flyte idl

Signed-off-by: Yee Hing Tong <[email protected]>

* test stuff

* Remove artifactID from literal oneof, add to metadata (#2)

* Triggers (#6)

* Minor changes to get time series example working #8

Signed-off-by: Yee Hing Tong <[email protected]>

* switch channel (#10)

Signed-off-by: Yee Hing Tong <[email protected]>

* fix tests ignore - pr into other pr (#1858)

Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/update idl ux (#1920)

Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/trigger (#1948)

* Add triggers
* Remove bind_partition_time and just assume users won't use that. It's just time_partition in the normal call function now.

Signed-off-by: Yee Hing Tong <[email protected]>

* remove the now deleted artifact spec (#1984)

Signed-off-by: Yee Hing Tong <[email protected]>

* Literal metadata model update (#2089)

Signed-off-by: Yee Hing Tong <[email protected]>

* Separate time partition (#2114)

Signed-off-by: Yee Hing Tong <[email protected]>

* Split service code (#2136)

Signed-off-by: Yee Hing Tong <[email protected]>

* remove empty files

Signed-off-by: Yee Hing Tong <[email protected]>

* add noneness check to metadata and add test

Signed-off-by: Yee Hing Tong <[email protected]>

* remove sandbox test for now

Signed-off-by: Yee Hing Tong <[email protected]>

* Artf/cleanup (#2158)

* add a test

Signed-off-by: Yee Hing Tong <[email protected]>

* try updates

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>

* Use python 3.9 to run make doc-requirements.txt

Signed-off-by: Eduardo Apolinario <[email protected]>

* reasons not msg

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants