Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous calls to set logging level #876

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Remove extraneous calls to set logging level #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions flytekit/clis/sdk_in_container/pyflyte.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ def main(ctx, config=None, pkgs=None, insecure=None):
"""
update_configuration_file(config)

# Update the logger if it's set
log_level = _internal_config.LOGGING_LEVEL.get() or _sdk_config.LOGGING_LEVEL.get()
if log_level is not None:
cli_logger.getLogger().setLevel(log_level)

ctx.obj = dict()

# Determine SSL. Note that the insecure option in this command is not a flag because we want to look
Expand Down
4 changes: 0 additions & 4 deletions flytekit/clis/sdk_in_container/serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ def serialize(ctx, image, local_source_root, in_container_config_path, in_contai
@click.option("-f", "--folder", type=click.Path(exists=True))
@click.pass_context
def workflows(ctx, folder=None):
cli_logger.getLogger().setLevel(logging.DEBUG)

if folder:
click.echo(f"Writing output to {folder}")

Expand All @@ -323,8 +321,6 @@ def fast(ctx):
@click.option("-f", "--folder", type=click.Path(exists=True))
@click.pass_context
def fast_workflows(ctx, folder=None):
cli_logger.getLogger().setLevel(logging.DEBUG)

if folder:
click.echo(f"Writing output to {folder}")

Expand Down