Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pull request template for flytekit #91

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Mar 7, 2020

TL;DR

Adds a standardized pull request template from boilerplate

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added a new pull_request_template.md. As there is no boilerplate for flytekit, I manually copied over the pull_request_template.md.

Tracking Issue

flyteorg/flyte#194

Follow-up issue

NA

 - Copying over pull_request_template.
 - Currently there is no boilerplate in the code
@kumare3 kumare3 merged commit 9dde3ad into master Mar 9, 2020
max-hoffman pushed a commit to dolthub/flytekit that referenced this pull request May 11, 2021
- Copying over pull_request_template.
 - Currently there is no boilerplate in the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants