Add cli option to update workflow #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
requested review from
kumare3,
matthewphsmith and
wild-endeavor
as code owners
flytekit/clis/flyte_cli/main.py
Outdated
| "--state", | ||
| type=_click.Choice(["active", "archived"]), | ||
| required=True, | ||
| help="Whether or not to set a workflow as actively visible in the UI." |
There was a problem hiding this comment.
trying to tie it back to 'active'... i'll reword
There was a problem hiding this comment.
We should say Ui/ cli. Default is active only
| This updates the state of the workflow specified by the ID. | ||
| :param id: flytekit.models.core.identifier.Identifier id: The ID representing a given task. | ||
| :param int state: Enum value from flytekit.models.workflow.WorkflowState | ||
| :return: |
There was a problem hiding this comment.
if this passes the return type from raw, can you copy paste here too?
wild-endeavor
approved these changes
Apr 3, 2020
max-hoffman
pushed a commit
to dolthub/flytekit
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change allows a user to update workflow state using the flyte-cli
Type
Are all requirements met?
Complete description
Tested on flyte staging and checked on portal that the state was correctly modified.
Tracking Issue
flyteorg/flyte#235
Follow-up issue
NA