-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap out inspect file location #991
Conversation
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
========================================
Coverage 86.28% 86.29%
========================================
Files 252 255 +3
Lines 24137 24284 +147
Branches 2747 2768 +21
========================================
+ Hits 20826 20955 +129
- Misses 2843 2856 +13
- Partials 468 473 +5
Continue to review full report at Codecov.
|
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
# import importlib | ||
# importlib.import_module("core.flyte_basics.hello_world") | ||
# | ||
# raise Exception("jfkdlsa") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove those?
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
TL;DR
If the decorator and the usage of your decorator are in different places, it seems the new logic will inadvertently use the module where the decorator is defined instead of where the task is defined.
Slack thread.
Type
Are all requirements met?
Complete description
Since the module is being correctly set by functools, we should just use that to get the file path.