Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Merge branch 'delete_sidecar_pod' of github.com:lyft/flyteplugins int…
Browse files Browse the repository at this point in the history
…o delete_sidecar_pod
  • Loading branch information
Surinder Singh committed Oct 10, 2019
2 parents 8ace758 + 040a74e commit 4b20662
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions go/tasks/v1/flytek8s/plugin_executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func (e *K8sTaskExecutor) CheckTaskStatus(ctx context.Context, taskCtx types.Tas
PhaseVersion: taskCtx.GetPhaseVersion(),
}

// NOTE: To ensure objects are cleaned up, the plugins needs a persistent step in addition to upstream plugin executor
// NOTE: To ensure objects are cleaned up, the plugins need a persistent step in addition to upstream plugin executor
// state machine. Once the object reaches its terminal state, we commit the completion in two steps:
// Round1: mark the object as deleted in state store (object's custom state)
// Round2: instead of regular retrieval (which may fail in this case), just delete the object
Expand All @@ -253,7 +253,6 @@ func (e *K8sTaskExecutor) CheckTaskStatus(ctx context.Context, taskCtx types.Tas
taskCtx.GetTaskExecutionID().GetGeneratedName(), err)
return types.TaskStatusUndefined, err
}

if objStatus == k8sObjectDeleted {
// kill the object execution if still live
if e.handler.GetProperties().DeleteResourceOnAbort {
Expand Down

0 comments on commit 4b20662

Please sign in to comment.