Update snowflake endpoints (#286)

* Update snowflake endpoint Signed-off-by: Kevin Su <[email protected]> * update endpoint Signed-off-by: Kevin Su <[email protected]> * update endpoint Signed-off-by: Kevin Su <[email protected]> * update endpoint Signed-off-by: Kevin Su <[email protected]> * update endpoint Signed-off-by: Kevin Su <[email protected]> * update endpoint Signed-off-by: Kevin Su <[email protected]> * update tests Signed-off-by: Kevin Su <[email protected]> * fix tests Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
flyteorg · Sep 28, 2022 · 60e2401 · 60e2401
1 parent b790ed3
commit 60e2401
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/flyteplugins/go/tasks/plugins/webapi/snowflake/integration_test.go b/flyteplugins/go/tasks/plugins/webapi/snowflake/integration_test.go
@@ -65,7 +65,7 @@ func TestEndToEnd(t *testing.T) {
 func newFakeSnowflakeServer() *httptest.Server {
 	statementHandle := "019e7546-0000-278c-0000-40f10001a082"
 	return httptest.NewServer(http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
-		if request.URL.Path == "/api/statements" && request.Method == "POST" {
+		if request.URL.Path == "/api/v2/statements" && request.Method == "POST" {
 			writer.WriteHeader(202)
 			bytes := []byte(fmt.Sprintf(`{
 			  "statementHandle": "%v",
@@ -75,7 +75,7 @@ func newFakeSnowflakeServer() *httptest.Server {
 			return
 		}
 
-		if request.URL.Path == "/api/statements/"+statementHandle && request.Method == "GET" {
+		if request.URL.Path == "/api/v2/statements/"+statementHandle && request.Method == "GET" {
 			writer.WriteHeader(200)
 			bytes := []byte(fmt.Sprintf(`{
 			  "statementHandle": "%v",
@@ -85,7 +85,7 @@ func newFakeSnowflakeServer() *httptest.Server {
 			return
 		}
 
-		if request.URL.Path == "/api/statements/"+statementHandle+"/cancel" && request.Method == "POST" {
+		if request.URL.Path == "/api/v2/statements/"+statementHandle+"/cancel" && request.Method == "POST" {
 			writer.WriteHeader(200)
 			return
 		}

diff --git a/flyteplugins/go/tasks/plugins/webapi/snowflake/plugin.go b/flyteplugins/go/tasks/plugins/webapi/snowflake/plugin.go
@@ -207,9 +207,9 @@ func buildRequest(method string, queryInfo QueryInfo, snowflakeEndpoint string,
 	var snowflakeURL string
 	// for mocking/testing purposes
 	if snowflakeEndpoint == "" {
-		snowflakeURL = "https://" + account + ".snowflakecomputing.com/api/statements"
+		snowflakeURL = "https://" + account + ".snowflakecomputing.com/api/v2/statements"
 	} else {
-		snowflakeURL = snowflakeEndpoint + "/api/statements"
+		snowflakeURL = snowflakeEndpoint + "/api/v2/statements"
 	}
 
 	var data []byte

diff --git a/flyteplugins/go/tasks/plugins/webapi/snowflake/plugin_test.go b/flyteplugins/go/tasks/plugins/webapi/snowflake/plugin_test.go
@@ -66,7 +66,7 @@ func TestBuildRequest(t *testing.T) {
 	token := "test-token"
 	queryID := "019e70eb-0000-278b-0000-40f100012b1a"
 	snowflakeEndpoint := ""
-	snowflakeURL := "https://" + account + ".snowflakecomputing.com/api/statements"
+	snowflakeURL := "https://" + account + ".snowflakecomputing.com/api/v2/statements"
 	t.Run("build http request for submitting a snowflake query", func(t *testing.T) {
 		queryInfo := QueryInfo{
 			Account:   account,