SageMaker types changes

[EngHabu]

TL;DR

• Use structs to unmarshal hyperparameterconfig,
• Read parameter ranges from inputs

Type

• Bug Fix
• Feature
• Plugin

Are all requirements met?

• Code completed
• Smoke tested
• Unit tests added
• Code documentation added
• Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#455

[codecov-io]

Codecov Report

Merging #123 into master will decrease coverage by 0.07%.
The diff coverage is 51.51%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   61.20%   61.13%   -0.08%     
==========================================
  Files         105      105              
  Lines        5941     5956      +15     
==========================================
+ Hits         3636     3641       +5     
- Misses       1930     1938       +8     
- Partials      375      377       +2     

Impacted Files	Coverage Δ
go/tasks/plugins/k8s/sagemaker/utils.go	68.00% <42.30%> (-1.73%)	⬇️
...o/tasks/plugins/k8s/sagemaker/plugin_test_utils.go	95.15% <84.61%> (-0.70%)	⬇️
...sks/plugins/k8s/sagemaker/hyperparameter_tuning.go	61.49% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6148f4...7148363. Read the comment docs.

[EngHabu]

ping @bnsblue @kumare3

[kumare3]

Will loook tomorrow morning

[bnsblue]

Trying to run end2end in a sandbox to go through some details. Will continue tomorrow morning.

[bnsblue]

@EngHabu I ran the test workflow you put inside your flytekit PR locally and was stepping through the code with it. I noticed that the input static_hyperparameters, which is NOT a ParameterRangeOneOf, can get past this UnmarshalStruct check (err == nil).
https://github.com/lyft/flyteplugins/pull/123/files#diff-0860ebd6bc768e12560fd1608c1053f3c78899a4c3028e82e17b70f59d86ffe5R148-R149

I could be wrong but I don't think this is as expected?

[bnsblue]

Otherwise, this PR LGTM.

[EngHabu]

Excellent point. What will happen in that scenario is that the we will skip this input. (won't be considered a tunable hyperparameter)... That's why I added this TODO: https://github.com/lyft/flyteplugins/pull/123/files#diff-0860ebd6bc768e12560fd1608c1053f3c78899a4c3028e82e17b70f59d86ffe5R188-R190
We can't reliably throw an error unless we can inspect the interface and recognize certain inputs as ParameterRanges... this is a bit tricky today because we use Generic/Proto to represent those inputs...