This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
K8s-Array - Retry at the subtask level instead of overall job #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
…eorg/flyteplugins into mtoledo/add-subtask-retries Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Signed-off-by: Miguel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read then delete this section
TL;DR
Currently if any subtask fails all subtasks will be retried. With this PR we will retry at the subtask level and only count it as a failure once a subtask has reached its max # of retries.
Type
Are all requirements met?
Complete description
We extend the status array by number of subtask * number of retries per subtask. We also now count Retryable Failures as part of the Phase Summary to report the next phase
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
_flyteorg/flyte#1276