This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Track RetryAttempt and Phase of ExternalResources #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
8 tasks
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 62.42% 62.45% +0.02%
==========================================
Files 142 142
Lines 8833 8845 +12
==========================================
+ Hits 5514 5524 +10
+ Misses 2819 2818 -1
- Partials 500 503 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
previously approved these changes
Jan 19, 2022
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
approved these changes
Jan 24, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* replaced Metadata proto in TaskInfo with ExternalResource array Signed-off-by: Daniel Rammer <[email protected]> * added ExternalResource documentation comments Signed-off-by: Daniel Rammer <[email protected]> * setting retry attempt on external resources Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests and lint issues Signed-off-by: Daniel Rammer <[email protected]> * tracking RetryAttempt for k8s array plugin using a CompactArray Signed-off-by: Daniel Rammer <[email protected]> * added a few comments Signed-off-by: Daniel Rammer <[email protected]> * setting RetryAttempts for awsbatch subtasks Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests and lint issues Signed-off-by: Daniel Rammer <[email protected]> * populating external resource index with original index Signed-off-by: Daniel Rammer <[email protected]> * updated comments Signed-off-by: Daniel Rammer <[email protected]> * updated flyteidl version Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Populating RetryAttempt and Phase on ExternalResources to track array subtasks.
Type
Are all requirements met?
Complete description
Created a new ExternalResources struct which contains metadata on, you may have guessed, external resources which replaces the Metadata protobuf stored in TaskInfo. This decision was made for two reasons (1) the phase maintained within flyteplugins for each subtask is a flyteplugins core.Phase rather than the TaskExecution.Phase from flyteidl (which is reported in the TaskExecutionEvent) and (2) in flytepropeller all the Metadata fields except external resources are being overwritten, plus we need to convert between the flyteplugin and flyteidl phases.
Tracking Issue
flyteorg/flyte#1838
Follow-up issue
NA