This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Delete sidecar pod when task completes. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Oct 10, 2019
EngHabu
reviewed
Oct 11, 2019
Co-Authored-By: Haytham AbuelFutuh <[email protected]>
kumare3
reviewed
Oct 11, 2019
EngHabu
reviewed
Oct 11, 2019
added 2 commits
October 11, 2019 11:03
EngHabu
approved these changes
Oct 11, 2019
EngHabu
pushed a commit
that referenced
this pull request
Oct 31, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
EngHabu
pushed a commit
that referenced
this pull request
Nov 1, 2019
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
katrogan
pushed a commit
that referenced
this pull request
Dec 17, 2019
1. Adds log plumbing for basic container tasks only. 2. Sets up some basic helper code that reads configs in order to create log links. This will be refactored later.
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Delete sidecar pod when task completes. * missing comment * Update plugin_executor.go * Update plugin_executor.go * in two steps * fix * Update plugin_executor.go * test fixes * tests * bogus comment * fixing k8s object state * debug logs * Update go/tasks/v1/flytek8s/k8splugin_state_test.go Co-Authored-By: Haytham AbuelFutuh <[email protected]> * cr feedback * cr feedback * cr feedback * removing djo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.