This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Update k8s array system retries max value #284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently the k8s array plugin uses the interruptible threshold for the maximum value in the bitarray tracking system failures for map task subtasks. If the bitarray attempts to store a value over it's maximum configured value it results in a panic (rather than throwing an error). Therefore, a panic may occur if the number of system retries exceeds the interruptible threshold. This PR uses the maximum number of retries as the maximum value in the system retries bitarray and therefore fixes the panic.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2788
Follow-up issue
NA