Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Update k8s array system retries max value #284

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Sep 2, 2022

TL;DR

Currently the k8s array plugin uses the interruptible threshold for the maximum value in the bitarray tracking system failures for map task subtasks. If the bitarray attempts to store a value over it's maximum configured value it results in a panic (rather than throwing an error). Therefore, a panic may occur if the number of system retries exceeds the interruptible threshold. This PR uses the maximum number of retries as the maximum value in the system retries bitarray and therefore fixes the panic.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

fixes flyteorg/flyte#2788

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #284 (edd3614) into master (e863c76) will not change coverage.
The diff coverage is 100.00%.

❗ Current head edd3614 differs from pull request most recent head cb37557. Consider uploading reports for the commit cb37557 to get more accurate results

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         145      145           
  Lines        9264     9264           
=======================================
  Hits         5863     5863           
  Misses       2866     2866           
  Partials      535      535           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/array/k8s/management.go 57.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hamersaw hamersaw merged commit 4f13b4b into master Sep 6, 2022
@hamersaw hamersaw deleted the bug/map-task-retry-panic branch September 6, 2022 22:23
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Daniel Rammer <[email protected]>

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants