This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
sending correct external resources for k8s-array plugin #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 62.27% 62.23% -0.05%
==========================================
Files 145 145
Lines 11511 11530 +19
==========================================
+ Hits 7169 7176 +7
- Misses 3797 3811 +14
+ Partials 545 543 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EngHabu
reviewed
Dec 13, 2022
Signed-off-by: Dan Rammer <[email protected]>
|
@EngHabu friendly ping: does this PR look good to go? Currently blocking flyteorg/flyte#3315 |
EngHabu
approved these changes
Feb 7, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* sending correct external resources for k8s-array plugin Signed-off-by: Dan Rammer <[email protected]> * bumping phase versions Signed-off-by: Dan Rammer <[email protected]> * using externalResources in aws-batch plugin Signed-off-by: Dan Rammer <[email protected]> * lint issues Signed-off-by: Dan Rammer <[email protected]> * fixed unit tests Signed-off-by: Dan Rammer <[email protected]> * removed unnecessary comments Signed-off-by: Dan Rammer <[email protected]> * reverted permanent failure computation Signed-off-by: Dan Rammer <[email protected]> --------- Signed-off-by: Dan Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Cache status of map tasks subtasks is not reported correctly. This PR fixes the issue, where all external resources may be correctly annotated with the correct cache status during execution.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA