This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
PodSpec NodeSelectors overwrite the default k8s plugin settings #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 147 147
Lines 11809 11809
=======================================
Hits 7363 7363
Misses 3882 3882
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Signed-off-by: Dan Rammer <[email protected]>
Merged
8 tasks
kumare3
approved these changes
Dec 27, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* PodSpec NodeSelectors overwrite the default k8s plugin settings Signed-off-by: Dan Rammer <[email protected]> * added unit test Signed-off-by: Dan Rammer <[email protected]> * better node selector value Signed-off-by: Dan Rammer <[email protected]> * fixed issue with unionmaps where k8s plugin overrides labels Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Dan Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently the
NodeSelectorsonPodTasksdo not overwrite the k8s plugin default node selectors, rather it is the opposite. This means that if the sameNodeSelectorexists in both locations the k8s plugin is preferred. This PR changes the preference so thatNodeSelectorson thePodTaskoverwrite those specified as defaults in the k8s plugin configuration.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA