This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Only create copilot sidecars if interface requires #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 63.02% 62.90% -0.12%
==========================================
Files 148 146 -2
Lines 12148 12162 +14
==========================================
- Hits 7656 7651 -5
- Misses 3912 3934 +22
+ Partials 580 577 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eapolinario
approved these changes
Feb 9, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* not creating sidecar uploader or downloader unnecessarily Signed-off-by: Daniel Rammer <[email protected]> * check on nil map is unnecessary Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Currently, Flyte injects a copilot init container to download inputs and a sidecar container to upload outputs of a task. This process only checks if the interface has inputs / outputs defined as
nil, rather then checking if the variable list exists and is empty as well. This means, depending on the definition, Flyte may inject a container to, for example, upload the outputs of a task when that task does not have any outputs. This PR validates variable existence to ensure copilot sidcars are not unnecessarily created.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3254
Follow-up issue
NA