This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
feat: add support for inter-cluster communication for Ray plugin #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 62.90% 64.09% +1.18%
==========================================
Files 146 146
Lines 12162 9873 -2289
==========================================
- Hits 7651 6328 -1323
+ Misses 3934 2967 -967
- Partials 577 578 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 125 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Abdullah Mobeen <[email protected]>
aybidi
force-pushed
the
ray-plugin-inter-cluster
branch
from
45cfdb9 to
32016aa
Compare
Signed-off-by: Abdullah Mobeen <[email protected]>
Signed-off-by: Abdullah Mobeen <[email protected]>
pingsutw
reviewed
Mar 17, 2023
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Abdullah Mobeen <[email protected]>
hamersaw
reviewed
Mar 18, 2023
Signed-off-by: Abdullah Mobeen <[email protected]>
Signed-off-by: Abdullah Mobeen <[email protected]>
Signed-off-by: Abdullah Mobeen <[email protected]>
hamersaw
approved these changes
Mar 20, 2023
|
Congrats on merging your first pull request! 🎉 |
2 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* feat: add inter-cluster com to ray plugin Signed-off-by: Abdullah Mobeen <[email protected]> * test: add tests for remote cluster Signed-off-by: Abdullah Mobeen <[email protected]> * refactor: move auth to config Signed-off-by: Abdullah Mobeen <[email protected]> * fix description Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Abdullah Mobeen <[email protected]> * refactor: move clusterconfig and auth to pluginmachinery k8s Signed-off-by: Abdullah Mobeen <[email protected]> * refactor: move clusterconfig and auth to pluginmachinery k8s Signed-off-by: Abdullah Mobeen <[email protected]> * chore: remove commented out code Signed-off-by: Abdullah Mobeen <[email protected]> --------- Signed-off-by: Abdullah Mobeen <[email protected]> Signed-off-by: Abdullah Mobeen <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR addresses the concern "Supporting customized k8s client in various k8s plugins" but narrows it down to the ray plugin. In short, users can configure ray plugin to do inter-cluster communication, essentially submitting a custom resource to a specified k8s cluster instead of the one flytepropeller runs on.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2883
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/