Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix array log link phase to show interpreted phase instead #33

Merged
merged 4 commits into from
Nov 16, 2019
Merged

Fix array log link phase to show interpreted phase instead #33

merged 4 commits into from
Nov 16, 2019

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Nov 15, 2019

  • Fix array log link phase to show interpreted phase instead
  • Add unit tests for env vars override in array tasks

wild-endeavor
wild-endeavor previously approved these changes Nov 15, 2019
View reviewed changes
@EngHabu EngHabu merged commit 3a30f6d into master Nov 16, 2019
katrogan pushed a commit that referenced this pull request Dec 17, 2019
@matthewphsmith @lyft-buildnotify-4
Don't Get Logs When Container Doesn't Exist Yet (#33)
f3f0ec7 
This fix is not urgent because by default all logs are disabled currently.

It appears one of two things is happening:

1. GetTaskStatus is being called prior to BuildResources
2. Containers cannot be immediately referenced following BuildResources

This is causing a panic due to an expected container not being found.
TESTS WERE BYPASSED
REVIEWS WERE BYPASSED
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
@EngHabu
Fix array log link phase to show interpreted phase instead (#33)
fbc2ee3 
* Use the correct phase in the log link

* Actually fix the env var override issue

* make unit tests deterministic

* PR Comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EngHabu @wild-endeavor