Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add nil check in databricks plugin #332

Merged
merged 3 commits into from
May 8, 2023
Merged

Add nil check in databricks plugin #332

merged 3 commits into from
May 8, 2023

Conversation

pingsutw
Copy link
Member

TL;DR

Add nil check in databricks plugin. should fix https://flyte-org.slack.com/archives/CP2HDHKE1/p1678980405562029?thread_ts=1678831311.261609&cid=CP2HDHKE1

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

^^^

Follow-up issue

NA

@pingsutw pingsutw marked this pull request as draft March 16, 2023 18:12
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #332 (0f60d03) into master (18a594e) will increase coverage by 1.31%.
The diff coverage is 0.00%.

❗ Current head 0f60d03 differs from pull request most recent head c79ed62. Consider uploading reports for the commit c79ed62 to get more accurate results

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   62.65%   63.97%   +1.31%     
==========================================
  Files         146      146              
  Lines       12220     9904    -2316     
==========================================
- Hits         7657     6336    -1321     
+ Misses       3981     2985     -996     
- Partials      582      583       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/webapi/databricks/plugin.go 65.65% <0.00%> (+3.52%) ⬆️

... and 129 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pingsutw pingsutw changed the title [WIP] Add nil check in databricks plugin Add nil check in databricks plugin Apr 9, 2023
@pingsutw pingsutw marked this pull request as ready for review April 9, 2023 19:08
@pingsutw pingsutw merged commit 76a80ec into master May 8, 2023
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants