Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Deprecated TransitionTypeBarrier #336

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

This PR deprecates TransitionTypeBarrier in support of removing support for BarrierTicks in FlytePropeller.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#3544

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #336 (2304c1e) into master (60d345d) will increase coverage by 1.23%.
The diff coverage is 41.66%.

❗ Current head 2304c1e differs from pull request most recent head a03ad9c. Consider uploading reports for the commit a03ad9c to get more accurate results

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   62.75%   63.98%   +1.23%     
==========================================
  Files         146      146              
  Lines       12194     9902    -2292     
==========================================
- Hits         7652     6336    -1316     
+ Misses       3964     2984     -980     
- Partials      578      582       +4     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/pluginmachinery/core/phase.go 22.09% <0.00%> (-3.49%) ⬇️
go/tasks/pluginmachinery/core/transition.go 100.00% <ø> (ø)
go/tasks/pluginmachinery/internal/webapi/core.go 25.00% <0.00%> (+2.27%) ⬆️
go/tasks/plugins/hive/executor.go 10.12% <0.00%> (+1.87%) ⬆️
go/tasks/plugins/presto/executor.go 11.26% <0.00%> (+1.96%) ⬆️
go/tasks/plugins/k8s/pod/plugin.go 78.46% <56.00%> (-2.56%) ⬇️
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️

... and 124 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hamersaw hamersaw merged commit 4f02c2c into master Apr 7, 2023
@hamersaw hamersaw deleted the housekeeping/remove-barrier-tick branch April 7, 2023 20:34
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
hamersaw added a commit that referenced this pull request Sep 26, 2023
hamersaw added a commit that referenced this pull request Sep 26, 2023
This reverts commit 4f02c2c.

Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants