This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Change kubeflow plugins to allow settings specs for different replica #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
cc @fg91 you are also working on this file |
added 3 commits
April 24, 2023 23:40
Signed-off-by: Yubo Wang <[email protected]>
Signed-off-by: Yubo Wang <[email protected]>
Signed-off-by: Yubo Wang <[email protected]>
yubofredwang
force-pushed
the
refactor_kfoperators
branch
from
3a53e39 to
4da8c4f
Compare
Signed-off-by: Yubo Wang <[email protected]>
yubofredwang
changed the title
Signed-off-by: Yubo Wang <[email protected]>
yubofredwang
force-pushed
the
refactor_kfoperators
branch
from
28b5e43 to
9626895
Compare
Signed-off-by: Yubo Wang <[email protected]>
Signed-off-by: Yubo Wang <[email protected]>
hamersaw
reviewed
May 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 62.76% 64.13% +1.37%
==========================================
Files 148 148
Lines 12444 10269 -2175
==========================================
- Hits 7810 6586 -1224
+ Misses 4038 3074 -964
- Partials 596 609 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yubo Wang <[email protected]>
hamersaw
previously approved these changes
May 9, 2023
Signed-off-by: Yubo Wang <[email protected]>
hamersaw
approved these changes
May 9, 2023
|
Congrats on merging your first pull request! 🎉 |
8 tasks
8 tasks
8 tasks
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…#345) * change pytorch plugin to accept new pytorch task idl Signed-off-by: Yubo Wang <[email protected]> * merge elastic config in Signed-off-by: Yubo Wang <[email protected]> * add unit tests for pytorch Signed-off-by: Yubo Wang <[email protected]> * add tfjob Signed-off-by: Yubo Wang <[email protected]> * add mpi job Signed-off-by: Yubo Wang <[email protected]> * add test to commone operator Signed-off-by: Yubo Wang <[email protected]> * update flyteidl Signed-off-by: Yubo Wang <[email protected]> * add function header comments Signed-off-by: Yubo Wang <[email protected]> * fix lint Signed-off-by: Yubo Wang <[email protected]> --------- Signed-off-by: Yubo Wang <[email protected]> Co-authored-by: Yubo Wang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Change kubeflow plugins to allow settings specs for different replica. The settings include: images, resources, command(mpi only), restart policy for different replica groups.
Corresponding PR in flyteidl: flyteorg/flyteidl#386
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#3308