This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add non-interruptible node selector requirement to spark driver if set #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeev B <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 62.64% 64.08% +1.43%
==========================================
Files 148 148
Lines 12397 10073 -2324
==========================================
- Hits 7766 6455 -1311
+ Misses 4036 3023 -1013
Partials 595 595
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 129 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hamersaw
reviewed
Apr 25, 2023
go/tasks/plugins/k8s/spark/spark.go
Outdated
| @@ -236,6 +236,9 @@ func (sparkResourceHandler) BuildResource(ctx context.Context, taskCtx pluginsCo | |||
| j.Spec.MainClass = &sparkJob.MainClass | |||
| } | |||
|
|
|||
| // Add non-interruptible node selector requirements to driver pod | |||
There was a problem hiding this comment.
I would just update the comment to specify that driver pods should never be interruptible so we hardcode to non-interruptible to apply relevant node selectors if they exist.
Signed-off-by: Jeev B <[email protected]>
jeevb
force-pushed
the
jeev/spark-non-interruptible-driver
branch
from
bd6d12d to
3c886d1
Compare
hamersaw
approved these changes
Apr 25, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
#346) * Add non-interruptible node selector requirement to spark driver if set Signed-off-by: Jeev B <[email protected]> * comment Signed-off-by: Jeev B <[email protected]> --------- Signed-off-by: Jeev B <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Spark driver pods should always run as non-interruptible. However, we do not apply the
non-interruptible-node-selector-requirementnode selector if set. As such, these pods may be scheduled incorrectly on interruptible nodes.Type
Are all requirements met?
Complete description
Always apply node selector requirements for non-interruptible to spark driver pods.