Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Only initializing maptask if there is no failure #352

Merged
merged 1 commit into from
May 24, 2023

Conversation

hamersaw
Copy link
Contributor

TL;DR

Checking state to ensure that the DetermineDiscoverability function does not fail before attempting to initialize ExternalResources for the maptask subtasks.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

fixes flyteorg/flyte#3709

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #352 (70efd26) into master (9a2bbba) will increase coverage by 1.40%.
The diff coverage is 84.44%.

❗ Current head 70efd26 differs from pull request most recent head 60d3ee6. Consider uploading reports for the commit 60d3ee6 to get more accurate results

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   62.77%   64.18%   +1.40%     
==========================================
  Files         148      148              
  Lines       12664    10283    -2381     
==========================================
- Hits         7950     6600    -1350     
+ Misses       4105     3073    -1032     
- Partials      609      610       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/tasks/plugins/k8s/ray/ray.go 77.48% <84.09%> (-0.09%) ⬇️
go/tasks/plugins/array/k8s/executor.go 40.67% <100.00%> (+1.09%) ⬆️

... and 129 files with indirect coverage changes

@hamersaw hamersaw merged commit 8a2f8ca into master May 24, 2023
@hamersaw hamersaw deleted the bug/maptask-exceed-size branch May 24, 2023 19:41
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] maptask panics when exceeding maxArrayJobsize
2 participants