This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Feat: Make pod start time available als logging link template variable in kubeflow plugin #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Graetz <[email protected]>
fg91
commented
Jun 14, 2023
| @@ -104,8 +105,11 @@ func GetMPIPhaseInfo(currentCondition commonOp.JobCondition, occurredAt time.Tim | |||
| } | |||
|
|
|||
| // GetLogs will return the logs for kubeflow job | |||
| func GetLogs(taskType string, name string, namespace string, hasMaster bool, | |||
| func GetLogs(taskType string, objectMeta meta_v1.ObjectMeta, hasMaster bool, | |||
There was a problem hiding this comment.
By passing in objectMeta as opposed to individually passing in the name, namespace and in the future also the creation timestamp, we can retrieve the creation timestamp only a single time here instead of doing so in pytorch.go, tensorflow.go, as well as mpi.go.
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 62.67% 64.04% +1.37%
==========================================
Files 152 152
Lines 12806 10389 -2417
==========================================
- Hits 8026 6654 -1372
+ Misses 4168 3123 -1045
Partials 612 612
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hamersaw
approved these changes
Jun 15, 2023
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Signed-off-by: Fabio Graetz <[email protected]>
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
I'd like to add the filter
timestamp >= podStartTimeto our stackdriver log link template. This is important because currently our users have to manually extend the time range (default 1h) each time they visit the stackdriver log page. (Unless the job started and finished within the past hour.)To this aim, I recently made the pod start and finish time available as logging link template variables in RFC3339 time format which is required by google cloud logging (#360).
Currently, the kubeflow plugin doesn't pass the pod start time to the log plugin though.
In this PR I extend the kubeflow plugin to do so.
Type
Are all requirements met?
Complete description
NA
Tracking Issue
NA
Follow-up issue
NA