This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Add support for using task execution ID fields in log URI templates #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 62.92% 64.23% +1.31%
==========================================
Files 153 154 +1
Lines 12901 10570 -2331
==========================================
- Hits 8118 6790 -1328
+ Misses 4170 3167 -1003
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Jeev B <[email protected]>
jeevb
commented
Jul 13, 2023
* Use a split templating scheme * add enum for TemplateScheme
pmahindrakar-oss
approved these changes
Jul 14, 2023
Nice, thanks, very useful :) |
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
…372) * Refactor task log templates to support extra vars * plumbing for k8s * Cleanup use of providers * cleanup * more cleanups * more cleanups * more cleanups * Plumb through task context for plugins * fix Signed-off-by: Jeev B <[email protected]> * move task execution identifier into Input struct * use pointer * tests Signed-off-by: Jeev B <[email protected]> * fix linting Signed-off-by: Jeev B <[email protected]> * cleanups * fix * revert to using regex replacements for performance * Readd benchmark * Split templating scheme (#373) * Use a split templating scheme * add enum for TemplateScheme * cleanup comment * fix linting issues * add unit tests for templateVarsForScheme * update for consistency --------- Signed-off-by: Jeev B <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new templating scheme,
TaskExecution
, that supports the following task execution metadata variables in the log link templates:Usage: