Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix generate check in CI #377

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Fix generate check in CI #377

merged 2 commits into from
Jul 15, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Jul 15, 2023

No description provided.

@jeevb jeevb marked this pull request as ready for review July 15, 2023 02:05
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #377 (697f2a8) into master (7ddd993) will increase coverage by 1.41%.
The diff coverage is 100.00%.

❗ Current head 697f2a8 differs from pull request most recent head 2398d52. Consider uploading reports for the commit 2398d52 to get more accurate results

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   62.89%   64.30%   +1.41%     
==========================================
  Files         154      154              
  Lines       13029    10563    -2466     
==========================================
- Hits         8195     6793    -1402     
+ Misses       4221     3157    -1064     
  Partials      613      613              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/pluginmachinery/tasklog/templatescheme_enumer.go 0.00% <ø> (ø)
go/tasks/plugins/webapi/bigquery/config_flags.go 45.71% <100.00%> (+7.47%) ⬆️

... and 133 files with indirect coverage changes

Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeevb jeevb merged commit e2eb4e5 into master Jul 15, 2023
@jeevb jeevb deleted the jeev/fix-generate-check branch July 15, 2023 07:40
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Fix generate check in CI

* Re-run `make generate`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants