This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Replace lower-cased sidecar gpu resource with nvidia one #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
previously approved these changes
Mar 7, 2020
@wild-endeavor done |
wild-endeavor
approved these changes
Mar 9, 2020
| @@ -27,13 +27,16 @@ | |||
| }], | |||
| "resources": { | |||
| "requests": { | |||
| "gpu": { | |||
There was a problem hiding this comment.
so the point of this test is that regardless of whether you specify gpu or the nvidia gpu, both work?
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses flyteorg/flyte#180 by substituting "gpu" from the sidecar custom resources with the fully nvdia gpu resource name.
When we build Flyte container tasks we never even use "GPU", but rather the full nvidia name (https://github.com/lyft/flytepropeller/blob/f487cfe6e4d35b52f6f9cb399cceb5abf4a0595a/pkg/utils/k8s.go#L58)
I believe only sidecar tasks are (incorrectly) using the "GPU" search string in flyteplugins