This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Pull request template for Flyteplugins #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrogan
previously approved these changes
Mar 7, 2020
bnsblue
previously approved these changes
Mar 7, 2020
wild-endeavor
previously approved these changes
Mar 7, 2020
kumare3
dismissed stale reviews from wild-endeavor, bnsblue, and katrogan
via
2eb2f8c
bnsblue
approved these changes
Mar 7, 2020
wild-endeavor
approved these changes
Mar 7, 2020
|
I made sure all unit tests pass. The changes are only in linters |
bnsblue
pushed a commit
to flyteorg/flyte
that referenced
this pull request
Apr 7, 2020
This deploys the changes from flyteorg/flytepropeller#200 lyft/flytedynamicjoboperator_DEPRECATED#98 flyteorg/flyteplugins#66 and changes the execution of the `hive` task type from the Qubole operator, to a plugin. It also add a pretty simple Redis deployment to use as a temporary FRM. **Note** that it currently uses and `emptyDir`, which means that if the Redis pod goes down, and it comes back up, we could potentially double the number of queries we want to run. If it goes down again, we could potentially triple. The yaml file for the redis deployment came from a local Helm deployment of redis. I then did an `-o yaml` get and heavily modified it and removed a bunch of stuff that wasn't needed. This PR does not remove the deployment of the Qubole operator yet, so we'll have to do that in a future PR, and the QuboleJob CRD will continue to function. Nothing will be using it though, so it should be okay.
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Pull request template for Flyteplugins * Linter fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds a standardized pull request template from boilerplate
Type
Are all requirements met?
Complete description
Added a new pull_request_template.md
Tracking Issue
flyteorg/flyte#194
Follow-up issue
NA