Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Populate ExecutionError Kind from Container Errors #83

Merged
merged 1 commit into from
May 5, 2020

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented May 4, 2020

TL;DR

FlyteKit populates a Container Error message that the plugin machinery then transforms into ExecutionError. In the process, we do not populate the execution error kind leading to tasks always getting tagged with Unknown Kind

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

flyteorg/flyte#300

@codecov-io
Copy link

codecov-io commented May 4, 2020

Codecov Report

Merging #83 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   55.01%   54.97%   -0.04%     
==========================================
  Files          91       91              
  Lines        4657     4660       +3     
==========================================
  Hits         2562     2562              
- Misses       1818     1821       +3     
  Partials      277      277              
Impacted Files Coverage Δ
...uginmachinery/ioutils/remote_file_output_reader.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87dec02...0504ffa. Read the comment docs.

@kumare3 kumare3 merged commit d46c654 into master May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants