remove terminated wfs' blob obj from cache

Signed-off-by: Babis Kiosidis <[email protected]>
flyteorg · Jul 25, 2022 · 840c098 · 840c098
1 parent 356fa33
commit 840c098
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/controller/handler.go b/pkg/controller/handler.go
@@ -190,6 +190,10 @@ func (p *Propeller) Handle(ctx context.Context, namespace, name string) error {
 
 	if w.GetExecutionStatus().IsTerminated() {
 		if HasCompletedLabel(w) && !HasFinalizer(w) {
+			// clear blobs from cache for terminated workflows
+			if w.WorkflowStaticExecutionObj != "" {
+				p.staticObjStore.Remove(ctx, w)
+			}
 			logger.Debugf(ctx, "Workflow is terminated.")
 			// This workflow had previously completed, let us ignore it
 			return nil

diff --git a/pkg/controller/staticobjstore/factory.go b/pkg/controller/staticobjstore/factory.go