This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Delete K8s Resources on abort for K8s plugins #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
changed the title
kumare3
approved these changes
Apr 22, 2020
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
GOPATH is not mandatory to have now and the source code may not be stored under GOPATH.
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Implement Abort() on PluginManager to attempt to delete the created Resources (e.g. Pods, Spark Applications... etc.). This ensures that we do not wait for the GC to run to let K8s kill them saving resources from being wasted.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#263