This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
feat; Catalog Information including Caching published to FlyteAdmin #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -133,7 +134,7 @@ func GenerateArtifactTagName(ctx context.Context, inputs *core.LiteralMap) (stri | |||
|
|
|||
| // Get the DataSetID for a task. | |||
| // NOTE: the version of the task is a combination of both the discoverable_version and the task signature. | |||
| // This is because the interfact may of changed even if the discoverable_version hadn't. | |||
| // This is because the interface may of changed even if the discoverable_version hadn't. | |||
There was a problem hiding this comment.
Suggested change
| // This is because the interface may of changed even if the discoverable_version hadn't. | |
| // This is because the interface may have changed even if the discoverable_version hadn't. |
wild-endeavor
previously approved these changes
Jul 29, 2020
wild-endeavor
approved these changes
Jul 29, 2020
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
#minor Updates Node Execution events to publish Catalog state to FlyteAdmin
Type
Are all requirements met?
Complete description
This would enable Catalog information visibility in the UI/CLI etc. it will also enable further enhancements in the User experience for Catalog
Tracking Issue
flyteorg/flyte#138
Follow-up issue
NA