This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Pick up latest plugins resource resolution & implement changes #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
katrogan
changed the title
EngHabu
reviewed
Oct 8, 2021
Signed-off-by: Katrina Rogan <[email protected]>
EngHabu
previously approved these changes
Oct 11, 2021
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
EngHabu
approved these changes
Oct 11, 2021
bimtauer
pushed a commit
to bimtauer/flytepropeller
that referenced
this pull request
Oct 20, 2021
…org#333) Signed-off-by: Tim Bauer <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Pick up latest plugins resource resolution and implements changes as required by latest TaskExecutionMetadata interface
Type
Are all requirements met?
Complete description
Testing documented in plugins PR description: flyteorg/flyteplugins#215
Tracking Issue
flyteorg/flyte#1450
flyteorg/flyte#1452
Follow-up issue
NA