This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add Union Type validation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
…ypes Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Mar 22, 2022
|
Congrats on merging your first pull request! 🎉 |
2 tasks
eapolinario
added a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Add Union Type validation * Update to use string tags * Fix go.mod + update typing tests * Restore ambiguity checking, add binding tests * Add union type promise binding tests * Do not use NONE as any type * Ditto * Implement changed design * Bump flyteidl to 0.24.0 Signed-off-by: Eduardo Apolinario <[email protected]> * Fix merge mistake in typing.go Signed-off-by: Eduardo Apolinario <[email protected]> * Add tests to bindings_test.go back Signed-off-by: Eduardo Apolinario <[email protected]> * Set `val` variable Signed-off-by: Eduardo Apolinario <[email protected]> * Lint Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Support for validating Tagged Union types
Type
Are all requirements met?
Complete description
https://github.com/maximsmol/flyte/blob/master/rfc/core%20language/sum-types.md
Tracking Issue
flyteorg/flyte#1349
Follow-up issue
NA