This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Take literal hash into account during cache key calculation #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
eapolinario
changed the title
Signed-off-by: Eduardo Apolinario <[email protected]>
EngHabu
previously approved these changes
Mar 1, 2022
Signed-off-by: Eduardo Apolinario <[email protected]>
This reverts commit 983ee6c. Signed-off-by: Eduardo Apolinario <[email protected]>
EngHabu
approved these changes
Mar 3, 2022
|
Congrats on merging your first pull request! 🎉 |
eapolinario
added a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…#406) * Point to flyteidl branch Signed-off-by: Eduardo Apolinario <[email protected]> * Set tag Signed-off-by: Eduardo Apolinario <[email protected]> * Add replaceHashInLiteral function Signed-off-by: Eduardo Apolinario <[email protected]> * Changes to propeller-config.yaml to run locally Signed-off-by: Eduardo Apolinario <[email protected]> * Pick up latest flyteidl@add-hash-to-literal Signed-off-by: Eduardo Apolinario <[email protected]> * Rename variables Signed-off-by: Eduardo Apolinario <[email protected]> * Add unit tests Signed-off-by: Eduardo Apolinario <[email protected]> * s/replaceHashInLiteral/hashify/g Signed-off-by: Eduardo Apolinario <[email protected]> * s/literalMapCopy/hashifiedLiteralMap/g Signed-off-by: Eduardo Apolinario <[email protected]> * Bump flyteidl Signed-off-by: Eduardo Apolinario <[email protected]> * Use flyteidl 0.23.0 Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Changes to propeller-config.yaml to run locally" This reverts commit 983ee6c. Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR implements the backend support for overriding the cache key calculation in the case of offloaded objects.
Type
Are all requirements met?
Complete description
As defined in flyteorg/flyte#1893, we're going to expose the ability to set a hash in the literal for caching purposes. This hash will take precedence over the representation of the literal during cache key calculation. Specifically, if a hash is set in a literal (including collections and maps), we use that literal hash to build the cache key (instead of the the literal value). In other words, we recursively traverse the literal to ensure all literals have their hash set iff the hash is set and use the resulting literal to generate a cache key.
Tracking Issue
fixes flyteorg/flyte#1581
Follow-up issue
NA