This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Graceful failure on ExecutionNotFound error #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow state Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
reviewed
May 17, 2022
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
honnix
reviewed
Jun 6, 2022
| @@ -1057,7 +1057,7 @@ func (c *nodeExecutor) AbortHandler(ctx context.Context, execContext executors.E | |||
| }, | |||
| ProducerId: c.clusterID, | |||
| }) | |||
| if err != nil && !eventsErr.IsEventIncompatibleClusterError(err) { | |||
| if err != nil && !eventsErr.IsNotFound(err) && !eventsErr.IsEventIncompatibleClusterError(err) { | |||
There was a problem hiding this comment.
Maybe we can extract a function to have a global "ignore list" check? This will start to get less maintainable.
EngHabu
approved these changes
Jun 6, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* updated ExecutionNotFound to check failed attempts rather than workflow state Signed-off-by: Daniel Rammer <[email protected]> * added unit test to allow continue until maxRetries Signed-off-by: Daniel Rammer <[email protected]> * added dropping ExecutionNotFound error when aborting workflow Signed-off-by: Daniel Rammer <[email protected]> * fixed unit tests Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updating the workflow abort pipeline to drop ExecutionNotFound errors. Previously, this solution could handle workflows that have not yet started, but for those that are already executing the events that are sent as part of aborting the workflow triggered a cycle.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2275
Follow-up issue
NA