This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
GetLaunchPlan checks for NotFound gRPC code rather than nil launchplan #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
approved these changes
Jun 6, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When executing a launchplan that does not exist propeller checks if the
err != nilbefore checking if thelp == nilhere. So when the launchplan doesn't exist it returns aRemoteSystemErrorwhich uses backoff retries rather than failing right away as a user error would. This PR checks the gRPC status code to correctly label the launchplan NotFound.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2404
Follow-up issue
NA