This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix prometheus metric panic when using additional labels #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
EngHabu
approved these changes
Jun 9, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* updated flytestdlib Signed-off-by: Daniel Rammer <[email protected]> * set flytestdlib to new release Signed-off-by: Daniel Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR pulls the fix from flytestdlib. The issue is that Golangs
appendimplementation may modify the underlying array. So when we use this to compute metric labels, we have the ability to corrupt the underlying array meaning other metrics will fail.Type
Are all requirements met?
Complete description
^^^
Tracking Issue
flyteorg/flyte#2597
Follow-up issue
NA