This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Extend pod webhook self-signed certs expiration date to 99 years in the future #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he future Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
Mar 4, 2023
EngHabu
approved these changes
Mar 4, 2023
These certs are created during startup (and currently we've had 2 instances of users who hit this in the wild). It's worth a q-a github discussion explaining how to get rid of this error (i.e. restart the flyte pod webhook). |
…-date-to-99-years
eapolinario
deleted the
extend-webhook-self-signed-cert-expiration-date-to-99-years
branch
eapolinario
added a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…he future (flyteorg#535) Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
1 year self-signed certs are not enough
Type
Are all requirements met?
Complete description
Tracking Issue
fixes flyteorg/flyte#2871
Follow-up issue
NA