Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Structured Dataset with generic format should be castable to Flyte Schema #536

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 4, 2023

TL;DR

we set default structured dataset format to empty ("") in this commit.
This workflow is unable to be registered because compiler expects downstream task format to be parquet, but in this case, it is generic.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

image

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #536 (685124c) into master (328a41c) will increase coverage by 0.49%.
The diff coverage is 33.33%.

❗ Current head 685124c differs from pull request most recent head bfae1c5. Consider uploading reports for the commit bfae1c5 to get more accurate results

@pingsutw pingsutw merged commit 48c37de into master Mar 8, 2023
@pingsutw pingsutw deleted the schema_bug branch March 8, 2023 19:20
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
…hema (flyteorg#536)

* Structured Dataset with generic format should be castable to Schema

Signed-off-by: Kevin Su <[email protected]>

* Structured Dataset with generic format should be castable to Schema

Signed-off-by: Kevin Su <[email protected]>

* update

Signed-off-by: Kevin Su <[email protected]>

---------

Signed-off-by: Kevin Su <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants