This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Update flyteplugins
#578
Merged
Update flyteplugins
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernhard Stadlbauer <[email protected]>
bstadlbauer
force-pushed
the
update-flyteplugins-1.1.3
branch
from
1a6c9e9 to
ee92ceb
Compare
Signed-off-by: Bernhard Stadlbauer <[email protected]>
Signed-off-by: Bernhard Stadlbauer <[email protected]>
|
@hamersaw Not quite sure what's failing the docker build step here 🤔 I saw |
Seems to be an issue with go version in the propeller Dockerfile. I'll get this fixed. |
Signed-off-by: Bernhard Stadlbauer <[email protected]>
hamersaw
reviewed
Jun 29, 2023
| if err != nil { | ||
| return "", err | ||
| return "", nil |
There was a problem hiding this comment.
Is returning nil here intended? Shouldn't this surface the error?
There was a problem hiding this comment.
Not intentional 🤦 Thanks for spotting, fixed in 4a19d66
Signed-off-by: Bernhard Stadlbauer <[email protected]>
hamersaw
approved these changes
Jul 5, 2023
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Update `flyteplugins` Signed-off-by: Bernhard Stadlbauer <[email protected]> * Update `flytepropeller` Signed-off-by: Bernhard Stadlbauer <[email protected]> * Fix imports Signed-off-by: Bernhard Stadlbauer <[email protected]> * Bump flyteplugins to v1.1.7 Signed-off-by: Bernhard Stadlbauer <[email protected]> * Return `err` instead of `nil` Signed-off-by: Bernhard Stadlbauer <[email protected]> --------- Signed-off-by: Bernhard Stadlbauer <[email protected]> Co-authored-by: Dan Rammer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updates
flytepluginsto the latest version.Removes all literal map hashing logic and replaces it with the one refactored into
flytepluginsin flyteorg/flyteplugins#363Type
Are all requirements met?