This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Fix usage of archive replacements #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardo apolinario <[email protected]>
hamersaw
approved these changes
Jul 5, 2023
This was referenced Jul 6, 2023
eapolinario
added a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Produce archives using the recommended alternative for archives.replacements
Type
Are all requirements met?
Complete description
archives.replacementswas deprecated and removed in the latest goreleaser version as per https://goreleaser.com/deprecations/#archivesreplacements. This PR follows the recommendation to usename_templateto get the same effect.I removed the unused
{{ .Arm }}block also.Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/