This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
BugFix: SubWorkflow and dynamic node handling failure #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 49.48% 49.62% +0.13%
==========================================
Files 127 123 -4
Lines 7881 7599 -282
==========================================
- Hits 3900 3771 -129
+ Misses 3598 3460 -138
+ Partials 383 368 -15
Continue to review full report at Codecov.
|
| return nil | ||
| } | ||
| logger.Info(ctx, "Finalizing Subworkflow") | ||
| wf := nCtx.Workflow() |
There was a problem hiding this comment.
yes because I want to move away from using a workflow and move to using just the contextual structure
| @@ -174,7 +175,24 @@ func (s *subworkflowHandler) HandleSubWorkflowFailingNode(ctx context.Context, n | |||
| return s.DoInFailureHandling(ctx, nCtx, contextualSubWorkflow) | |||
| } | |||
|
|
|||
| func (s *subworkflowHandler) HandleAbort(ctx context.Context, nCtx handler.NodeExecutionContext, w v1alpha1.ExecutableWorkflow, workflowID v1alpha1.WorkflowID) error { | |||
| func (s *subworkflowHandler) HandleAbort(ctx context.Context, nCtx handler.NodeExecutionContext, w v1alpha1.ExecutableWorkflow, workflowID v1alpha1.WorkflowID, reason string) error { | |||
| subWorkflow := w.FindSubWorkflow(workflowID) | |||
There was a problem hiding this comment.
the w here is the highest level, parent workflow?
added 3 commits
March 12, 2020 00:20
Increment was called before calling the abort. Since the logic is derived using the current attempt number, everything broke
EngHabu
previously approved these changes
Mar 12, 2020
| @@ -374,6 +374,7 @@ func (c *nodeExecutor) handleNode(ctx context.Context, w v1alpha1.ExecutableWork | |||
| return executors.NodeStatusUndefined, err | |||
| } | |||
|
|
|||
| nodeStatus.IncrementAttempts() | |||
There was a problem hiding this comment.
Can you add docs for why we should do it here and not after the handle() returns?
| @@ -614,7 +615,7 @@ func TestLaunchPlanHandler_HandleAbort(t *testing.T) { | |||
|
|
|||
| t.Run("abort-success", func(t *testing.T) { | |||
| mockLPExec := &mocks.Executor{} | |||
| //mockStore := storage.NewCompositeDataStore(storage.URLPathConstructor{}, storage.NewDefaultProtobufStore(utils.FailingRawStore{}, promutils.NewTestScope())) | |||
| // mockStore := storage.NewCompositeDataStore(storage.URLPathConstructor{}, storage.NewDefaultProtobufStore(utils.FailingRawStore{}, promutils.NewTestScope())) | |||
wild-endeavor
previously approved these changes
Mar 12, 2020
EngHabu
previously approved these changes
Mar 12, 2020
wild-endeavor
approved these changes
Mar 13, 2020
20 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Handling Finalize for subworkflows * config change * improved logging * Fixing the regression Increment was called before calling the abort. Since the logic is derived using the current attempt number, everything broke * updated and fixed tests * comment updated * updated * More unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#202
Follow-up issue
NA