Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemVerge MMCloud Agent #1128

Merged
merged 5 commits into from
Oct 2, 2023
Merged

MemVerge MMCloud Agent #1128

merged 5 commits into from
Oct 2, 2023

Conversation

edwinyyyu
Copy link
Contributor

@edwinyyyu edwinyyyu commented Sep 13, 2023

Add Integrations documentation and example for MemVerge MMCloud agent plugin.

Merge after packaging and updating requirements:
flyteorg/flytekit#1821

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linting error, would you mind taking a look

@edwinyyyu edwinyyyu marked this pull request as draft September 18, 2023 17:31
@@ -0,0 +1,2 @@
flytekitplugins-envd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to run pip-compile (see here) to make sure requirements.txt is compiled (currently it's an empty file)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error No matching distribution found for flytekitplugins-mmcloud when running pip-compile on this. I think it's because flytekitplugins-mmcloud has not been published yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to wait for flytekitplugins-mmcloud to be published in the next flytekit release to merge the flytesnacks docs

@cosmicBboy
Copy link
Contributor

the build error is fixed here: #1148 @pingsutw can you approve that one?

@pingsutw pingsutw marked this pull request as ready for review September 30, 2023 04:00
@cosmicBboy cosmicBboy enabled auto-merge (squash) October 2, 2023 17:37
@cosmicBboy
Copy link
Contributor

@helenzhangyc would you mind make this PR up-to-date with the base branch?

@helenzhangyc
Copy link
Contributor

@helenzhangyc would you mind make this PR up-to-date with the base branch?

just updated!

@cosmicBboy cosmicBboy merged commit fe4968d into flyteorg:master Oct 2, 2023
85 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants