Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openai batch example #1667

Merged
merged 17 commits into from
May 24, 2024
Merged

add openai batch example #1667

merged 17 commits into from
May 24, 2024

Conversation

samhita-alla
Copy link
Contributor

@samhita-alla samhita-alla commented Apr 25, 2024

This PR adds an example to demonstrate the OpenAI Batch agent.

Fixes flyteorg/flyte#5274

Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
@samhita-alla samhita-alla marked this pull request as ready for review May 15, 2024 17:53
Signed-off-by: Samhita Alla <[email protected]>
neverett
neverett previously approved these changes May 16, 2024
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestions, otherwise LGTM

Signed-off-by: Samhita Alla <[email protected]>
@samhita-alla
Copy link
Contributor Author

thanks for reviewing, @neverett! will merge this PR after merging the flytekit PR.

@samhita-alla
Copy link
Contributor Author

@neverett can you merge flyteorg/flyte#5411 PR after the tests pass and then rerun the failed check in this PR? this PR should be good to merge after all the tests pass.

@neverett
Copy link
Contributor

@samhita-alla flyteorg/flyte#5411 has been merged, but the monodocs build is still failing here for unrelated reasons (probably related to the multiple build failures mentioned here). I can rerun the monodocs build and merge this PR once that other issue is resolved.

@samhita-alla
Copy link
Contributor Author

@neverett could you please approve and merge?

@pingsutw pingsutw merged commit 988de2d into master May 24, 2024
56 checks passed
@pingsutw pingsutw deleted the add-openai-batch-api-example branch May 24, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration] OpenAI Batch API Agent
3 participants