Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for flytedeck Opt In #915

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Update docs for flytedeck Opt In #915

merged 5 commits into from
Oct 28, 2022

Conversation

Smartmind12
Copy link
Contributor

Signed-off-by: Utsav Paul [email protected]

Closes #flyteorg/flyte#3016

@Smartmind12
Update deck.py
bed79ed 
Signed-off-by: Utsav Paul <[email protected]>
@Smartmind12
Update deck.py
3d7e02b 
Signed-off-by: Utsav Paul <[email protected]>
@Smartmind12
Copy link
Contributor Author

@samhita-alla I have completed the updation...kindly review!

pingsutw
pingsutw reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this line and this one to @task(disable_deck=False)

@Smartmind12
Update deck.py
1114ebb 
Signed-off-by: Utsav Paul <[email protected]>
@Smartmind12
Copy link
Contributor Author

Smartmind12 commented Oct 27, 2022 •
edited
Loading

Need to update this line and this one to @task(disable_deck=False)

Updated!

@samhita-alla samhita-alla merged commit ad5d53a into flyteorg:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhita-alla samhita-alla samhita-alla left review comments

@pingsutw pingsutw pingsutw approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Smartmind12 @samhita-alla @pingsutw