Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gate node example to the control flow section of flytesnacks #968

Merged
merged 23 commits into from
Mar 16, 2023

Conversation

cosmicBboy
Copy link
Contributor

wild-endeavor and others added 10 commits March 9, 2023 15:54
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy
Copy link
Contributor Author

this is blocked by flyteorg/flyte#3461

eapolinario and others added 2 commits March 14, 2023 15:17
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
cosmicBboy and others added 5 commits March 14, 2023 19:04
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
@eapolinario
Copy link
Collaborator

The failure we're seeing is real, I was able to repro it in local sandbox as well:

❯ pwd
/Users/eduardo/repos/flytesnacks/cookbook/core/type_system

❯ pyflyte run --remote structured_dataset.py schema_compatibility_wf --a 3
{"asctime": "2023-03-14 23:51:04,033", "name": "flytekit", "levelname": "WARNING", "message": "FlyteSchema is deprecated, use Structured Dataset instead."}
Failed with Exception: Reason: SYSTEM:Unknown
RPC Failed, with Status: StatusCode.INTERNAL
        details: failed to compile workflow for [resource_type:WORKFLOW project:"flytesnacks" domain:"development" name:"core.type_system.structured_dataset.schema_compatibility_wf" version:"4rTAVVM9xZF2Jilgvc4cOA==" ] with err failed to compile workflow with err Collected Errors: 2
        Error 0: Code: MismatchingTypes, Node Id: n1, Description: Variable [o0] (type [schema:<columns:<name:"Name" type:STRING > columns:<name:"Age" > columns:<name:"Height" > > ]) doesn't match expected type [structured_dataset_type:<columns:<name:"Age" literal_type:<simple:INTEGER > > > ].
        Error 1: Code: ParameterNotBound, Node Id: n1, Description: Parameter not bound [df].

        Debug string UNKNOWN:Error received from peer ipv6:%5B::1%5D:30080 {grpc_message:"failed to compile workflow for [resource_type:WORKFLOW project:\"flytesnacks\" domain:\"development\" name:\"core.type_system.structured_dataset.schema_compatibility_wf\" version:\"4rTAVVM9xZF2Jilgvc4cOA==\" ] with err failed to compile workflow with err Collected Errors: 2\n\tError 0: Code: MismatchingTypes, Node Id: n1, Description: Variable [o0] (type [schema:<columns:<name:\"Name\" type:STRING > columns:<name:\"Age\" > columns:<name:\"Height\" > > ]) doesn\'t match expected type [structured_dataset_type:<columns:<name:\"Age\" literal_type:<simple:INTEGER > > > ].\n\tError 1: Code: ParameterNotBound, Node Id: n1, Description: Parameter not bound [df].\n", grpc_status:13, created_time:"2023-03-14T23:51:05.241902-07:00"}

eapolinario
eapolinario previously approved these changes Mar 15, 2023
Signed-off-by: Niels Bantilan <[email protected]>

Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy enabled auto-merge (squash) March 16, 2023 16:07
@cosmicBboy cosmicBboy merged commit 878271d into master Mar 16, 2023
@cosmicBboy cosmicBboy deleted the gate-example branch March 16, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Signaling: Create Flytesnacks example under "Control Flow" section
4 participants